Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit return_items_attributes return_reason_id #4080

Merged
merged 1 commit into from
May 27, 2021
Merged

Permit return_items_attributes return_reason_id #4080

merged 1 commit into from
May 27, 2021

Conversation

spaghetticode
Copy link
Member

@spaghetticode spaghetticode commented May 25, 2021 •
edited
Loading

When creating a new customer return, the admin interface allows to edit the return reason for return items, but the parameter was rejected by the controller since it was actually not permitted, thus preventing the editing of that field.

Screen Shot 2021-05-25 at 9 24 46 AM

Screen Shot 2021-05-25 at 9 25 25 AM

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@spaghetticode
Permit return_items_attributes return_reason_id
86be2f8 
When creating a new customer return, the admin interface allows to
edit the return reason for return items, but the parameter was
rejected by the controller since it was actually not permitted,
thus preventing the editing of that field.
@spaghetticode spaghetticode added the type:bug Error, flaw or fault label May 25, 2021
@spaghetticode spaghetticode self-assigned this May 25, 2021
kennyadsl
kennyadsl approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we need to backport this one.

@kennyadsl kennyadsl added Needs Backport changelog:solidus_backend Changes to the solidus_backend gem labels May 25, 2021
@kennyadsl kennyadsl merged commit bbc5dfe into solidusio:master May 27, 2021
@kennyadsl kennyadsl deleted the spaghetti/permit-return_reason_id branch May 27, 2021 16:09
@spaghetticode spaghetticode mentioned this pull request May 31, 2021
Merged
5 tasks
kennyadsl added a commit that referenced this pull request Jun 1, 2021
@kennyadsl
Merge pull request #4090 from spaghetticode/spaghetticode/permit-retu…
07bdb8d 
…rn_reason_id

Backport #4080 to Solidus 2.11
@spaghetticode spaghetticode mentioned this pull request Jun 1, 2021
Merged
5 tasks
kennyadsl added a commit that referenced this pull request Jun 9, 2021
@kennyadsl
Merge pull request #4091 from spaghetticode/permit-return_reason_id
df13a47 
Backport #4080 to Solidus 3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees

@spaghetticode spaghetticode

Labels
changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spaghetticode @kennyadsl @jarednorman @gmacdougall