Add an HTML select element to filter orders by the shipment state #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willianveiga
changed the title
|
Spec failures seem legit: Can you please address this? Thanks! |
|
Closed by mistake 🤦 Done, @kennyadsl. Thanks. |
|
This looks good. Do you mind squashing the commits together? |
willianveiga
force-pushed
the
feature/filter-order-by-shipment-status
branch
2 times, most recently
from
85f06d3 to
238ccb5
Compare
|
I squashed both commits, @jarednorman. Thanks. |
jarednorman
approved these changes
Jun 1, 2021
|
Thanks! Looks good. |
kennyadsl
reviewed
Jun 7, 2021
| @@ -48,6 +48,10 @@ | |||
| <%= f.text_field :shipments_number_start %> | |||
| </div> | |||
|
|
|||
| <div class="field"> | |||
| <%= label_tag :q_shipment_state, t('spree.shipment_state') %> | |||
| <%= f.select :shipment_state_eq, %i[backorder canceled partial pending ready shipped].map { |s| [t("spree.shipment_states.#{s}"), s] }, { include_blank: true }, { class: "custom-select fullwidth" } %> | |||
There was a problem hiding this comment.
I prefer to have a longer line (especially because it's already very long) but without the single-letter variable. Can we please change s into state?
willianveiga
force-pushed
the
feature/filter-order-by-shipment-status
branch
from
238ccb5 to
15af307
Compare
jarednorman
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an HTML select element to filter orders by the shipment state.
Fixes #4023
Checklist: