Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clearer default answer in prompt #4101

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Make clearer default answer in prompt #4101

merged 1 commit into from
Jun 14, 2021

Conversation

waiting-for-dev
Copy link
Contributor

The install generator adds solidus_auth_deviseto the stack by default.
I.e., the gem is installed when carriage return is pressed without
explicitly typing y or n. The most common convention is to make the
default answer capitalized.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@waiting-for-dev
Make clearer default answer in prompt
22d4f64 
The install generator adds `solidus_auth_devise`to the stack by default.
I.e., the gem is installed when carriage return is pressed without
explicitly typing `y` or `n`. The most common convention is to make the
default answer capitalized.
kennyadsl
kennyadsl approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jarednorman jarednorman merged commit 63501e7 into solidusio:master Jun 14, 2021
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/fix_prompt_default_case branch June 15, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waiting-for-dev @kennyadsl @jarednorman