Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix staled upgrade instructions on the Gemfile's post-install message #4166

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Fix staled upgrade instructions on the Gemfile's post-install message #4166

merged 1 commit into from
Sep 15, 2021

Conversation

waiting-for-dev
Copy link
Contributor

The old upgrade task was removed in #4157

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

kennyadsl
kennyadsl approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kennyadsl
kennyadsl approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waiting-for-dev!

@kennyadsl kennyadsl added type:bug Error, flaw or fault Needs Backport labels Sep 15, 2021
@kennyadsl kennyadsl merged commit d859a5b into solidusio:master Sep 15, 2021
@kennyadsl kennyadsl deleted the waiting-for-dev/fix_post_install_message branch September 15, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waiting-for-dev @kennyadsl @jarednorman