Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track coverage while installing solidus #5398

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Track coverage while installing solidus #5398

wants to merge 1 commit into from

Conversation

elia
Copy link
Member

@elia elia commented Sep 29, 2023

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Sep 29, 2023
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Sep 29, 2023
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus_admin labels Oct 6, 2023
@elia elia force-pushed the elia/solidus-install-coverage branch from b470aa4 to 4fe0fb4 Compare January 3, 2024 13:40
@github-actions github-actions bot removed changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_sample Changes to the solidus_sample gem labels Jan 3, 2024
@elia elia force-pushed the elia/solidus-install-coverage branch from 4fe0fb4 to e45c304 Compare January 3, 2024 14:30
@elia elia force-pushed the elia/solidus-install-coverage branch from e45c304 to b76d1a8 Compare January 3, 2024 14:31
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12d7504) 88.58% compared to head (570119e) 88.18%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5398      +/-   ##
==========================================
- Coverage   88.58%   88.18%   -0.40%     
==========================================
  Files         685      118     -567     
  Lines       16402     2311   -14091     
==========================================
- Hits        14529     2038   -12491     
+ Misses       1873      273    -1600

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elia elia force-pushed the elia/solidus-install-coverage branch from b76d1a8 to 570119e Compare January 15, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elia elia

Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elia