[legacy_promotions]: Correct decorator naming #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want to use these decorators with Zeitwerk, their naming scheme has to exchange module name and type. For example, app/decorators/solidus_legacy_promotions/models/line_item_decorator.rb becomes app/decorators/models/solidus/legacy_promotions/line_item_decorator.rb This will eventually allow us to use Zeitwerk for loading decorators.
github-actions
bot
added
the
changelog:solidus_legacy_promotions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5946 +/- ##
==========================================
- Coverage 89.54% 89.45% -0.09%
==========================================
Files 782 782
Lines 17997 17997
==========================================
- Hits 16116 16100 -16
- Misses 1881 1897 +16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mamhoff
force-pushed
the
correct-decorator-naming
branch
from
c6f6c47
to
fe18ce3
Compare
adammathys
approved these changes
Nov 20, 2024
tvdeyen
reviewed
Nov 20, 2024
| @@ -6,6 +6,10 @@ module SolidusLegacyPromotions | |||
| class Engine < ::Rails::Engine | |||
| include SolidusSupport::EngineExtensions | |||
|
|
|||
| initializer "solidus_legacy_promotions.patch_state_machine", after: "spree.load_config_initializers" do | |||
| config.to_prepare { SolidusLegacyPromotions::SpreeOrderStateMachineDecorator } | |||
There was a problem hiding this comment.
Would like to leave a comment here on why this is necessary
There was a problem hiding this comment.
@mamhoff saw you added it as commit message. 👍🏻 for this, but I still like to have a code comment here.
Solidus Support's new Zeitwerk-based loading mechanism only works for decorating autoloaded classes. The order state machine is in `lib`, and thus is not autoloaded, so this decorator is not loaded either unless we explicitly load it.
mamhoff
force-pushed
the
correct-decorator-naming
branch
from
fe18ce3
to
e639857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the file names of decorators in the
solidus_legacy_promotionsgem to match Zeitwerk's expectations.solidus_promotionsis actually entirely fine.This has been tested with solidusio/solidus_support#87, but is fully compatible with the classic way of loading each and every decorator on every app reload.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: