updating positions via update_positions via js/persistence using acts_as_list has an issue #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javascript is sending indices starting from 0. acts_as_list has top_of_list defaulted as 1 - Source: https://github.com/swanandp/acts_as_list/blob/master/lib/acts_as_list/active_record/acts/list.rb#L38 Steps to reproduce the Issue: 1. Go to images under product. 2. Take any element after the 1st one to the top. 3. Edit the one at the top (that was just dragged) 4. Coming back to the index page shows it in the 2nd position. What is happening in the frontend? 1. Javascript sends the indices starting 0. 2. The update_positions method in resource_controller just sets the positions as they were sent (with more stuff going on) 3. When element in the 0th position is modified. acts_as_list figures 1 is the top of the list and sets the value to 1 along with setting anything which is already in position 1 to 0. This fix will not modify existing positions, but will only fix those resources for new updates. Another solution could be to set the configuration for all models which use acts_as_list to top_of_list: 0 which could be an alternative solution which fixes this issue from re-occurring in the first place.
sairam
changed the title
|
👍 Nice catch. Thank you. I'm trying to see if there's a good way to add a regression test for this. Testing drag interactions through capybara is pretty awkward. |
|
@jhawthorn Let me know if you'd want me to add any specific tests. I am trying to get familiar with the codebase. |
|
Calling this good, thanks a lot @sairam |
cbrunsdon
added a commit
that referenced
this pull request
Jan 11, 2016
updating positions via update_positions via js/persistence using acts_as_list has an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript is sending indices starting from 0.
acts_as_list gem has top_of_list defaults to 1
Steps to reproduce the Issue:
What is happening in the frontend?
This fix will not modify existing positions, but will only fix those resources for new updates.
Alternate solution could be to set the configuration for models (sample location) which use acts_as_list to
top_of_list: 0which could be an alternative solution which fixes this issue from re-occurring in the first place.