Remove Order::CurrencyUpdater #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was intended to be used to update line items in an order to a new currency. Nowhere do we allow reassigning a currency to an existing order, or to line items, so this should not be needed. I don't think we should support changing currencies at all. If this was desirable behaviour for a store, they should implement it themselves as there are many caveats.
|
👍 |
|
I'm 👍 on this. For the future, if anyone is looking for this functionality, I highly suggest it be handled at the time the currency is being changed and not as a before_update. |
|
👍 |
cbrunsdon
added a commit
that referenced
this pull request
Jan 6, 2016
Remove Order::CurrencyUpdater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split this off from #425, as I think the remainder of that PR (OrderUpdater change) scared people more than this portion.
This was intended to be used to update line items in an order to a new currency. Nowhere do we allow reassigning a currency to an existing order, or to line items, so this should not be needed.