Update to remove deprecation warnings #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubocop was going nut with the previous version
as rubocop likes
The old syntax is deprecated
This will remove deprecation messages
prior to the new gateways design payment methods were inheriting from Spree::Gateway and they needed to be instantiated by calling `provider`. This commit makes it possible to support both versions. It uses the new method added into 0.2.2 of solidus_support, this is why the dependency has been updated.
kennyadsl
force-pushed
the
update-payment-parent-class
branch
from
c9b0a6f to
1477850
Compare
tvdeyen
approved these changes
Oct 9, 2018
| @@ -1,12 +1,13 @@ | |||
| module SolidusAffirm | |||
| class Gateway < Spree::Gateway | |||
| class Gateway < SolidusSupport.payment_method_parent_class | |||
There was a problem hiding this comment.
Some day it would be great to rename this class into what is actually is (a SolidusAffirm::PaymentMethod), but this would force existing stores to change data on their database and therefor should be done in a mayor release instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After solidusio/solidus#2001 we need to change some stuff to remove deprecation warning and be compliant with the next solidus versions.
This PR also update some code to be rubocop and factor bot compliant.