Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kafka Cruise Control UI #22

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

double16
Copy link

No description provided.

@solsson
Copy link
Owner

solsson commented Feb 14, 2019

Is the UI meant to run in the same container as Cruise Control? Would we for example switch to this build in https://github.com/Yolean/kubernetes-kafka/blob/master/cruise-control/50cruise-control.yml and open up a port?

@double16
Copy link
Author

double16 commented Feb 14, 2019

Yes, in the same container, in the same process actually. Cruise Control can serve static content along with the REST endpoints. One of the supported configs for the UI is to add the files into the directory already configured to serve content. This PR does this.

I would like to switch 50cruise-control.yml to use the new image. The UI is served over the same port as the API. Port 8090 is already opened, so no additional work.

@solsson
Copy link
Owner

solsson commented Feb 14, 2019

Great! The Cruise Control setup is a perfect example of a community effort. I still don't know anything about Cruse Control and we nevertheless have it up and running :) I'll build a new image and bump in a kubernetes-kafka branch that you can verify.

@solsson solsson merged commit 2dadb71 into solsson:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants