-
-
Notifications
You must be signed in to change notification settings - Fork 92
Conversation
@@ -22,9 +21,9 @@ | |||
class TreeController extends Controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need such a controller in this bundle or will this all move to the tree bundle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The controller is for the tree block, which is still used.
cool! i am happy to merge as soon as the tests are cleaned up. we should create issues for the currently abandoned functionality like valid_children however, so that we do not forget this. and yes, lets add things to CHANGELOG.md and if possible also UPGRADE.md. doing this later will become much harder when we don't remember that well what we did. |
Fixed the tests and updated the changelog. |
thanks a lot! as soon as it becomes clear, we should start writing a migration guide as well. but maybe wait until its more clear how the new things will work exactly. |
What do you mean with "a migration guide"? |
instructions how to upgrade a project from using admin 1.x to use admin 2.0. "upgrade guide" would be a better name probably. |
A cleanup of the bundle for the treebrowserbundle cleanup. Atm, the bundle is broken. This fixes it.
It contains some big BC breaks (removing tree for instance). Should I note this in the CHANGELOG file? (which doesn't contain any 2.0 changes atm)
Other things to be aware of: