Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Cleanup for TreeBrowserBundle 2.0 #339

Merged
merged 6 commits into from
May 7, 2015
Merged

Conversation

wouterj
Copy link
Contributor

@wouterj wouterj commented May 5, 2015

A cleanup of the bundle for the treebrowserbundle cleanup. Atm, the bundle is broken. This fixes it.

It contains some big BC breaks (removing tree for instance). Should I note this in the CHANGELOG file? (which doesn't contain any 2.0 changes atm)

Other things to be aware of:

  • This now means that valid_children is no longer used. It's not very hard to implement it for the "create" action, but for displaying it requires new features in the resource bundle (/cc @dantleech am I correct or does it already have such feature?)
  • Some options are now commented, I wanted to leave them in so we see what's still missing.
  • Selected node is now no longer needed, as the treebrowser supports binding to the input field (automatically selecting based on the input field)

@wouterj wouterj changed the title Cleanup Cleanup for TreeBrowserBundle 2.0 May 5, 2015
@@ -22,9 +21,9 @@
class TreeController extends Controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need such a controller in this bundle or will this all move to the tree bundle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The controller is for the tree block, which is still used.

@dbu
Copy link
Contributor

dbu commented May 6, 2015

cool! i am happy to merge as soon as the tests are cleaned up. we should create issues for the currently abandoned functionality like valid_children however, so that we do not forget this.

and yes, lets add things to CHANGELOG.md and if possible also UPGRADE.md. doing this later will become much harder when we don't remember that well what we did.

@wouterj
Copy link
Contributor Author

wouterj commented May 6, 2015

Fixed the tests and updated the changelog.

dbu added a commit that referenced this pull request May 7, 2015
Cleanup for TreeBrowserBundle 2.0
@dbu dbu merged commit d6c232d into sonata-project:master May 7, 2015
@dbu
Copy link
Contributor

dbu commented May 7, 2015

thanks a lot! as soon as it becomes clear, we should start writing a migration guide as well. but maybe wait until its more clear how the new things will work exactly.

@wouterj wouterj deleted the cleanup branch May 7, 2015 13:08
@wouterj
Copy link
Contributor Author

wouterj commented May 7, 2015

What do you mean with "a migration guide"?

@dbu
Copy link
Contributor

dbu commented May 8, 2015

instructions how to upgrade a project from using admin 1.x to use admin 2.0. "upgrade guide" would be a better name probably.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants