-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update commands #1765
Update commands #1765
Conversation
Can we add this to 3.x branch and should I add changelog for it? |
I made the same change some time ago at sonata-project/SonataAdminBundle#5579, so I think we could assume the same BC break here. |
Can you add changelog? @phansys do we need an upgrade note about this BC break? No one is suposed to extend those commands and IMO we should consider it as non BC break (as we did on admin bundle) but maybe it is good to add a note |
Many of our classes are not supposed to be extended, but since it's possible we usually treat them as part of our API. |
@jordisala1991 @phansys Can you help me with finish this PR? What more I should do? |
You should add an upgrade note to mention the BC break on this PR |
dadd6ab
to
446c184
Compare
446c184
to
bdcdd31
Compare
6a54322
to
be0d9eb
Compare
In |
👍 and I guess as the other one that it's possible that the service is not available. |
be0d9eb
to
29f75eb
Compare
@jordisala1991 @phansys Can you check upgrade and changelog notes? |
510e765
to
6a1d46d
Compare
16ca2fd
to
5abadb7
Compare
5abadb7
to
22fce78
Compare
22fce78
to
bab71cc
Compare
if (method_exists(Alias::class, 'setDeprecated')) {
$container->getAlias('Symfony\Bridge\Doctrine\RegistryInterface')->setDeprecated(true, 'The "%alias_id%" service alias is deprecated, use "Doctrine\Persistence\ManagerRegistry" instead.');
$container->getAlias('Doctrine\Bundle\DoctrineBundle\Registry')->setDeprecated(true, 'The "%alias_id%" service alias is deprecated, use "Doctrine\Persistence\ManagerRegistry" instead.');
$container->getAlias('Doctrine\Common\Persistence\ManagerRegistry')->setDeprecated(true, 'The "%alias_id%" service alias is deprecated, use "Doctrine\Persistence\ManagerRegistry" instead.');
} |
bab71cc
to
80f115f
Compare
Could you please rebase your PR and fix merge conflicts? |
80f115f
to
4a4ff85
Compare
4a4ff85
to
e09ec14
Compare
Update tests/Command/RemoveThumbsCommandTest.php Co-authored-by: Javier Spagnoletti <[email protected]> Update tests/Command/RemoveThumbsCommandTest.php Co-authored-by: Javier Spagnoletti <[email protected]> Update tests/Command/FixMediaContextCommandTest.php Co-authored-by: Javier Spagnoletti <[email protected]> Update UPGRADE-3.x.md Co-authored-by: Javier Spagnoletti <[email protected]> Update src/Command/MigrateToJsonTypeCommand.php Co-authored-by: Javier Spagnoletti <[email protected]> Update src/Command/FixMediaContextCommand.php Co-authored-by: Javier Spagnoletti <[email protected]>
50095d2
to
bc65199
Compare
Thank you @wbloszyk |
Subject
Replace
ContainerAwareCommand
in favor forCommand
and useDI
in favor forcontainer
.I am targeting this branch, because this should be done in this branch but technicly it is BC-break.
Changelog