Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french translation for image_too_small error message #1743 #1771

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Add french translation for image_too_small error message #1743 #1771

merged 1 commit into from
Jul 28, 2020

Conversation

romainjanvier
Copy link
Contributor

@romainjanvier romainjanvier commented Jul 28, 2020

Subject

Add missing french translation for image_too_small error message #1743

I am targeting this branch, because these changes respect BC.

This message added with #1743 is only present in en and de translation files but I'm only able to translate it in french.

Changelog

### Added
- Added french translation for image_too_small error message

@jordisala1991
Copy link
Member

Should this be pedantic or patch? @sonata-project/contributors

@core23 core23 removed the pedantic label Jul 28, 2020
@core23 core23 merged commit 25f0f21 into sonata-project:3.x Jul 28, 2020
@jordisala1991
Copy link
Member

If it is a patch, can you add changelog @romainjanvier . Thanks for your contribution btw :)

@greg0ire
Copy link
Contributor

greg0ire commented Jul 28, 2020

It affects end users so I'd say patch

@romainjanvier
Copy link
Contributor Author

Changelog added in PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants