Drop support for doctrine/mongodb-odm <2.0 #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| @@ -61,6 +61,7 @@ | |||
| }, | |||
| "conflict": { | |||
| "doctrine/dbal": "<2.6.0", | |||
| "doctrine/mongodb-odm": "<2.0", | |||
There was a problem hiding this comment.
how do we test the mongodb here? Maybe adding the mongodbadmin dependency? like we do with the orm
There was a problem hiding this comment.
mmm the only test I found is https://github.com/sonata-project/SonataMediaBundle/blob/315fe533dd4237243e6964efddaa314482970077/tests/Document/MediaManagerTest.php and there is no need of the library.
|
Could you please rebase your PR and fix merge conflicts? |
We are dropping support for doctrine/mongodb-odm 2.0, this allows us to not install alcaeus/mongo-php-adapter in GA for tests
franmomu
force-pushed
the
drop_support_mongodb_1
branch
from
4de8647 to
8677a0b
Compare
VincentLanglet
approved these changes
Sep 27, 2020
phansys
approved these changes
Sep 27, 2020
|
Thanks @franmomu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Ref: sonata-project/dev-kit#1069
We are dropping support for doctrine/mongodb-odm <2.0, this allows us to not install
alcaeus/mongo-php-adapterin GA for tests.I am targeting this branch, because these changes are BC.
Changelog