Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate calling getContext() without existing context #2021

Merged

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Closes #2014 .

Changelog

### Deprecated
- Deprecate `getContext()` from Pool without first having that context.

@jordisala1991 jordisala1991 requested review from VincentLanglet and a team August 8, 2021 14:12
@jordisala1991 jordisala1991 changed the title Deprecate calling getContext without existing context Deprecate calling getContext() without existing context Aug 8, 2021
VincentLanglet
VincentLanglet previously approved these changes Aug 8, 2021
@VincentLanglet VincentLanglet requested a review from a team August 8, 2021 14:13
@jordisala1991 jordisala1991 reopened this Aug 10, 2021
Co-authored-by: Javier Spagnoletti <[email protected]>
@jordisala1991 jordisala1991 requested review from phansys and a team August 10, 2021 14:16
@jordisala1991 jordisala1991 merged commit bf00a0d into sonata-project:3.x Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate getting context from Pool without checking first if it exists
3 participants