Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getName on blocks for SonataPageBundle #2042

Merged

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Closes #1962 .

Changelog

### Added
- Added name for blocks so they can be recognized on SonataPageBundle.

@jordisala1991
Copy link
Member Author

@haivala does this fixes your issue?

@jordisala1991 jordisala1991 requested review from VincentLanglet and a team August 14, 2021 14:46
@VincentLanglet
Copy link
Member

This method was deprecated from the interface https://github.com/sonata-project/SonataBlockBundle/blob/b161b8273366bec8d878e8e5a5c91a270eba3aa2/CHANGELOG.md#deprecated-2

So it require a NEXT_MAJOR to remove them in master. (And I don't know how it will be handle by the PageBundle)

@jordisala1991 jordisala1991 force-pushed the hotfix/get-name-on-blocks branch from 1661e2a to 54088c5 Compare August 15, 2021 14:17
@jordisala1991
Copy link
Member Author

This method was deprecated from the interface https://github.com/sonata-project/SonataBlockBundle/blob/b161b8273366bec8d878e8e5a5c91a270eba3aa2/CHANGELOG.md#deprecated-2

So it require a NEXT_MAJOR to remove them in master. (And I don't know how it will be handle by the PageBundle)

Added NEXT_MAJOR comment. On SonataPageBundle 4.x it will be handled using https://github.com/sonata-project/SonataMediaBundle/blob/master/src/Block/FeatureMediaBlockService.php#L104-L109
already implemented on all blocks.

@jordisala1991 jordisala1991 requested review from VincentLanglet and removed request for VincentLanglet August 15, 2021 14:19
@jordisala1991 jordisala1991 merged commit 0e55cf9 into sonata-project:3.x Aug 15, 2021
@jordisala1991 jordisala1991 deleted the hotfix/get-name-on-blocks branch August 15, 2021 15:53
@haivala
Copy link
Contributor

haivala commented Aug 15, 2021

@haivala does this fixes your issue?

Yes! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocks don't have name in SonataPageBundles composer
3 participants