Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MediaDownloadAction #2138

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Implement MediaDownloadAction #2138

merged 1 commit into from
Sep 30, 2021

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Sep 27, 2021 •
edited
Loading

Subject

I am targeting this branch, because this is BC.

Closes #2136

Changelog

### Added
- Added new Action to download medias 
### Deprecated
- Deprecated download medias through `MediaController` downloadAction.

@jordisala1991 jordisala1991 force-pushed the feature/move-to-actions branch 2 times, most recently from df7bcd5 to 6cf2f33 Compare September 29, 2021 06:44
@jordisala1991 jordisala1991 force-pushed the feature/move-to-actions branch from 6cf2f33 to 1ff4fc8 Compare September 29, 2021 07:06
@jordisala1991 jordisala1991 marked this pull request as ready for review September 29, 2021 07:07
@jordisala1991 jordisala1991 requested a review from a team September 29, 2021 07:09
@VincentLanglet VincentLanglet requested a review from a team September 29, 2021 07:20
@jordisala1991 jordisala1991 merged commit 12d483d into sonata-project:3.x Sep 30, 2021
@jordisala1991 jordisala1991 deleted the feature/move-to-actions branch September 30, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MediaController downloadAction by a Action class without extending AbstractController
2 participants
@jordisala1991 @VincentLanglet