Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate passing null to twig media functions #2158

Merged

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Changelog

### Deprecated
- Deprecated passing null value for the media parameter to twig functions.

@jordisala1991 jordisala1991 marked this pull request as draft October 8, 2021 06:41
@jordisala1991 jordisala1991 force-pushed the deprecation/null-value branch from b2c14f5 to 005e239 Compare October 9, 2021 07:12
@jordisala1991 jordisala1991 marked this pull request as ready for review October 9, 2021 07:12
@jordisala1991 jordisala1991 requested a review from a team October 9, 2021 07:13
@jordisala1991 jordisala1991 force-pushed the deprecation/null-value branch from 005e239 to 8d7f545 Compare October 9, 2021 07:17
franmomu
franmomu previously approved these changes Oct 9, 2021
VincentLanglet
VincentLanglet previously approved these changes Oct 9, 2021
@jordisala1991 jordisala1991 dismissed stale reviews from VincentLanglet and franmomu via dd87bc2 October 9, 2021 18:56
@jordisala1991 jordisala1991 force-pushed the deprecation/null-value branch 2 times, most recently from dd87bc2 to 707ac75 Compare October 9, 2021 18:58
@jordisala1991 jordisala1991 requested a review from a team October 9, 2021 19:00
core23
core23 previously approved these changes Oct 9, 2021
VincentLanglet
VincentLanglet previously approved these changes Oct 9, 2021
VincentLanglet
VincentLanglet previously approved these changes Oct 9, 2021
@jordisala1991 jordisala1991 merged commit 1f6dbc8 into sonata-project:3.x Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants