Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate using master and slave #2186

Merged
merged 2 commits into from
Oct 30, 2021
Merged

Deprecate using master and slave #2186

merged 2 commits into from
Oct 30, 2021

Conversation

jordisala1991
Copy link
Member

Subject

I am targeting this branch, because this is BC.

Changelog

### Deprecated
- Deprecate using `master` and `slave` for filesystem and cdn configuration, use `primary` and `secondary` instead.

@jordisala1991 jordisala1991 requested a review from a team October 30, 2021 07:10
@jordisala1991 jordisala1991 force-pushed the feature/deprecate-master-slave branch from f9081de to 9ea9219 Compare October 30, 2021 08:01
@jordisala1991 jordisala1991 requested review from core23 and a team October 30, 2021 08:03
@core23 core23 requested a review from a team October 30, 2021 08:09
@VincentLanglet VincentLanglet merged commit 67689d6 into sonata-project:3.x Oct 30, 2021
@VincentLanglet
Copy link
Member

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordisala1991 @VincentLanglet @core23