Use jsonb to avoid problems on batch delete

[jordisala1991]

Subject

I am targeting this branch, because this is the safe branch to do it.

Changelog

### Fixed
- Fixed usage of this bundle with PostgreSQL.

[jordisala1991]

@lukepass do you use MySQL? if so, can you check if this PR breaks your database schema in any way?

[jordisala1991]

Maybe it is better to just add the jsonb option to not do more hard BC breaks. @VincentLanglet

(we have more usages of json fields in SonataPageBundle)
(The roles field will become an array again , that was a mistake when removing FOSUserBundle)

[lukepass]

Should I just go on this branch and launch migrations or make some media upload?

[jordisala1991]

Yes please, go to this branch and try to launch migrations. Also if you could remove your media table and try to update the schema again, to ensure nothing changes, would be helpful.

Thank you :)

[core23]

Should we add tests for this?

[jordisala1991]

I don't think it is really easy to test. The problem with the distinct query is only when you do a batch delete.

I think we might start with testing on different databases instead of trying to reproduce the problem that this PR solves.

Anyway we shouldn't block the PR for its test IMO. I guess if it does not break with Sqlite we are fine.

[VincentLanglet]

I personally don't block the PR for unit/functional test, but for real tests.

I'd like to avoid to release the 4.0 with a major bug for mysql user and then be in the situation where reverting the change introduce a bug for mongo users.

[core23]

Did not test this, but looks okay so far

[core23]

IMHO we can release the stable 4.0 release after merging this. The last RC release was in November.

[VincentLanglet]

Yes, I just wait for someone, like lukepass, to test this.

[lukepass]

Yes! Sorry monday I will test it. Thanks! Il sab 22 gen 2022, 19:06 Vincent Langlet ***@***.***> ha scritto:

…

Yes, I just wait for someone, like lukepass, to test this. — Reply to this email directly, view it on GitHub <#2267 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRB2CKRDPBRDSLUXZOYRW3UXLW2RANCNFSM5MNAMBIA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[lukepass]

It generated a migration:

<?php

declare(strict_types=1);

namespace DoctrineMigrations;

use Doctrine\DBAL\Schema\Schema;
use Doctrine\Migrations\AbstractMigration;

/**
 * Auto-generated Migration: Please modify to your needs!
 */
final class Version20220124085858 extends AbstractMigration
{
    public function getDescription(): string
    {
        return '';
    }

    public function up(Schema $schema): void
    {
        // this up() migration is auto-generated, please modify it to your needs
        $this->addSql('ALTER TABLE media__media CHANGE provider_metadata provider_metadata JSON DEFAULT NULL');
    }

    public function down(Schema $schema): void
    {
        // this down() migration is auto-generated, please modify it to your needs
        $this->addSql('ALTER TABLE media__media CHANGE provider_metadata provider_metadata JSON DEFAULT NULL');
    }
}

I executed it and made some tests, it seems all ok! The schema didn't break and the previous data didn't corrupt.