-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make compat with sf5.0 form and parameter type declarations in conjun… #169
Conversation
…ction with the CollectionType
…ction with the CollectionType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda wonder if there is a way to cast the name somewhere else (before this class) in order to do the cast only once. But I have no idea;
Co-authored-by: Vincent Langlet <[email protected]>
Co-authored-by: Vincent Langlet <[email protected]>
Co-authored-by: Vincent Langlet <[email protected]>
Co-authored-by: Vincent Langlet <[email protected]>
I was wondering the same, but after thinking a bit about it, its the duty of this class to iterate over collections and detect size etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a better solution to propose, so let's approve. This needs to be squash-merged (or you can squash it yourself, OP)
How to do that?
git rebase -i origin/3.x
, assumingorigin
is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, rungit remote -vvv
, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.- A window will show up with many lines, replace
pick
withfixup
on every line but the first one - Close your editor, git should do its magic, and you should end up with one commit
- Use
git push --force
to overwrite what you already push. Don't forget the--force
option otherwise git will try to merge both things together.
Thanks @phiamo ! |
Ok @franmomu, I requested a new release for form-extensions via Slack in If you want to get notified about new releases, make sure to follow SonataNews on Twitter! |
They don't declare |
make compat with sf5.0 form and parameter type declarations in conjunction with the CollectionType
When using the Collection Type we get numbers (indice of the form collection) as keys, since they are int's
the symfony5.0 type declaration throws an exception since it requires a string.
Casting to string before all calls fixes this
I am targeting this branch, because it would make next version compatible with symfony5.0 as well.
Changelog