Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevKit updates for 1.x branch #400

Merged
merged 4 commits into from
Mar 9, 2023
Merged

DevKit updates for 1.x branch #400

merged 4 commits into from
Mar 9, 2023

Conversation

SonataCI
Copy link
Collaborator

@SonataCI SonataCI commented Mar 5, 2023 •
edited by VincentLanglet
Loading

Changelog

### Removed
- Support for PHP 7.4
- Support for Symfony 6.0 and 6.1

jordisala1991
jordisala1991 reviewed Mar 8, 2023
View reviewed changes
src/Type/BaseStatusType.php
*
* @phpstan-var class-string
*/
protected $class;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also cause bc breaks if child clases redeclare protected $class, since now it is protected string $class.

@jordisala1991 jordisala1991 merged commit d80df93 into 1.x Mar 9, 2023
@jordisala1991 jordisala1991 deleted the 1.x-dev-kit branch March 9, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SonataCI @jordisala1991 @VincentLanglet