Upgrade Eonasdan Date Picker #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
changed the title
jordisala1991
force-pushed
the
feature/upgrade-datepicker-2
branch
20 times, most recently
from
19e6c00 to
cf5288d
Compare
|
This PR replaces previous one, with better implementation: #335 Probably test coverage should be improved, but for now, @VincentLanglet wdyt? |
jordisala1991
commented
May 6, 2023
jordisala1991
commented
May 6, 2023
jordisala1991
commented
May 6, 2023
jordisala1991
force-pushed
the
feature/upgrade-datepicker-2
branch
3 times, most recently
from
26e7f31 to
8dc6add
Compare
jordisala1991
commented
May 6, 2023
jordisala1991
force-pushed
the
feature/upgrade-datepicker-2
branch
from
8dc6add to
2392993
Compare
jordisala1991
commented
May 6, 2023
jordisala1991
force-pushed
the
feature/upgrade-datepicker-2
branch
7 times, most recently
from
6fd0465 to
2fd751f
Compare
|
I think this should be almost done. Things missing:
@VincentLanglet since none of the above should change already written code, if you want to do a second round of review it would be nice. |
|
Works perfect on my side with SonataAdmin v4. Please review @VincentLanglet |
This was referenced May 7, 2023
Closed
jordisala1991
force-pushed
the
feature/upgrade-datepicker-2
branch
from
fab4906 to
0743d63
Compare
VincentLanglet
approved these changes
May 9, 2023
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this breaks BC, older date picker and new date picker do not share same options.
Closes #320.
Closes #362.
Changelog