Bump dep #416
Merged
Bump dep #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json
Outdated
| @@ -21,9 +21,9 @@ | |||
| ], | |||
| "homepage": "https://github.com/sonata-project/sonata-doctrine-extensions", | |||
| "require": { | |||
| "php": "^7.4 || ^8.0", | |||
| "php": "^8.0", | |||
| "doctrine/dbal": "^2.13 || ^3.1", | |||
There was a problem hiding this comment.
we could also drop dbal 2
| /** | ||
| * NEXT_MAJOR: Make the arguments mandatory. | ||
| */ | ||
| private function __construct(?string $type = null, ?string $fieldName = null, ?string $targetEntity = null) | ||
| private function __construct(private ?string $type = null, ?string $fieldName = null, ?string $targetEntity = null) |
| * @psalm-suppress UndefinedPropertyFetch | ||
| */ | ||
| $container = method_exists($this, 'getContainer') ? static::getContainer() : static::$container; | ||
| $container = static::getContainer(); |
There was a problem hiding this comment.
I guess you can avoid OTV (one time variable)
Any idea why @jordisala1991 ? |
| "doctrine/persistence": "^1.3.6 || ^2.0 || ^3.0" | ||
| "php": "^8.0", | ||
| "doctrine/dbal": "^3.3.6", | ||
| "doctrine/persistence": "^2.0 || ^3.0" | ||
| }, | ||
| "require-dev": { | ||
| "doctrine/common": "^2.7 || ^3.0", |
There was a problem hiding this comment.
this should be bumped too right?
Maybe the minimum of2.0 of persistence? |
I found a way to solve them. |
28 tasks
jordisala1991
approved these changes
May 22, 2022
franmomu
reviewed
May 22, 2022
| "friendsofphp/php-cs-fixer": "^3.4", | ||
| "jackalope/jackalope-doctrine-dbal": "^1.0", | ||
| "jackalope/jackalope-doctrine-dbal": "^1.7.6", |
There was a problem hiding this comment.
is this dependency still needed? I think it was used along with phpcr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}.
Changelog