-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dot files supported by jekyll not supported in generator config #141
Comments
digging into how https://github.com/sondr3/generator-jekyllized/blob/master/generators/jekyll/templates/build.js#L10 |
Thanks! Didn't think about this as I don't use Apache or anything requiring dotfiles, I'll fix this one as well as soon as I can! |
Okay, so I'm fixing this one right now but do we need to add support for dotfiles to both GitHub Pages and Amazon AWS? As far as I know neither of those have any files that are dotfiles, whereas for rsync you might need them for Apache and such. Any feedback? |
Second part of fixing sondr3/generator-jekyllized#141.
I tend to always lean towards predictability -- if part of the process copies files into a staging location ( Yes, probably not needed for github or aws (that I know of) but if a developer using this has one in their project it should probably be deployed (and then ignored by the 'server') I'd say that because this choice/config is buried in a dependent package I'd also lean towards being more accepting in that package by default. |
Alright, sounds good to me, I'll update them and push a new version pretty soon. |
And done! I accidentally tagged the wrong commit so I'll have to close it myself, I'll create a new release of both generators ASAP. |
My .htaccess file is not being copied into 'dist' when I run 'gulp build'. I'm using latest RC. I've also tried adding as an include in _config. |
Crap, I can see why, when updating your app it only looks at what has changed from |
There's no rush. Thanks for your great work. |
I just pushed a new version to Github, you can update to it with |
While the jekyll default config has support for some dot files (such as
.htaccess
) they were not being moved fromsrc
totmp
on the copy steps that precede the jekyll processing, so any build or deploy I was doing was not inclusive of these files.Locally, I fixed this by adding
,{dot: true}
to the appropriategulp.src()
calls in mygulpfile.js
.The text was updated successfully, but these errors were encountered: