-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sopel: drop support for Python 3.6 and require 3.7+ #2227
Conversation
Might as well take this opportunity to add 3.10 to CI, no? |
I've no idea what I missed here. |
It's because that check is marked as required in the repo settings. Before merging I would just have to update the list of expected checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions from me should be the only changes needed to add Python 3.10 to CI and reflect its "officially supported" status in the package once built.
So Github CI thinks it's "3.1" and not "3.10"... weird. |
Alright, now we can see that Python 3.10 is not supported by |
I see a lot of our transitive requirements in the "not supported" category, too—stuff we don't use directly, but that things we require depend on. Let's abandon adding 3.10 in this patch and try again after the next |
13703d5
to
e469d37
Compare
Weird, there is an isup test that fails in all three versions. I'm looking at potential cause, so here is the version installed:
I'll test locally to see if I can reproduce or not. |
I can confirm that with |
e469d37
to
bb73a55
Compare
Following Python 3.7 documentation, I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, for your INI-tweaking pleasure.
36201bc
to
9631e88
Compare
Yup, fixed it and squashed it. Didn't change anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess passing CI is our proof that trailing commas in flake8 config don't matter. 😁
Description
Tin. Python 3.6 died yesterday. I checked the warning for 3.6, they were written for Sopel 8, so we can either keep 3.6 or drop it now. Either way, this is not a big change, unlike Python 2.
I haven't modified the usage of
OrderedDict
, because there are slight difference betweendict
andOrderedDict
in particular when considering equality.I haven't check the "future" import either, hence the "draft" status for now.
Checklist
make qa
(runsmake quality
andmake test
)