logger: convert newlines to spaces in IRC logging handler

[dgw]

Description

Tin. Stupid-simple "fix" for #2207.

/cc @RhinosF1

Checklist

• I have read CONTRIBUTING.md
• I can and do license this contribution under the EFLv2
• No issues are reported by make qa (runs make quality and make test)
• I have tested the functionality of the things this change touches

Notes

I discovered while trying to test this on top of #2249 that setting logging_channel_level = DEBUG causes some serious problems. That probably warrants its own issue, but since @Exirel will probably be the one to review this I wanted to see if he has any advice first before I go digging around in things to write up a real report.

[Exirel]

Maybe we should also consider sending this in multiple messages? IIRC bot.say doesn't allow multi-line messages.

[dgw]

I thought about putting it in multiple messages, but decided not to for two main reasons:

1. This is a stable-version patch and I don't want to make a significant behavior change
2. Excessive output already seems to cause problems if the IRC logger is set to DEBUG (see OP notes section), so it doesn't currently seem like a good idea to spit out potentially 5-10 lines per log message

[Exirel]

Excessive output already seems to cause problems

Maybe it's time to deprecate such logger...

if the IRC logger is set to DEBUG (see OP notes section)

Also we should probably filter out DEBUG in any case for that logger (that's easy to do with logging config).

[dgw]

Excessive output already seems to cause problems

Maybe it's time to deprecate such logger...

The use case is valid, so I wouldn't go that far.

if the IRC logger is set to DEBUG (see OP notes section)

Also we should probably filter out DEBUG in any case for that logger (that's easy to do with logging config).

Probably yes, logging to IRC should not allow the more verbose log levels. Too much output in my testing with logging_channel_level = DEBUG led to a bunch of messages about flooding via handleError, though I don't have the exact output available to copy and paste into this comment rn.