Spawn processes with LANG that's guaranteed to exist #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LANG=en_US` is not guaranteed to exist on any system (it does not, for strange reasons, exist on mine). Choose `LANG=C`, which is guaranteed to exist. It has the side-effect of typically using an encoding other than UTF-8 for the tool output (e.g., ISO 8859-1). Apart from messages printed into the log in this encoding that should hopefully have no negative side-effects. See sorenlouv#505 for a case where code was assuming that output would always be English, and failed if it wasn't.
|
This LGTM. Thanks for the contribution. Is #505 still needed if this is merged? |
|
Released in 9.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LANG=en_USis not guaranteed to exist on any system (it does not, forstrange reasons, exist on mine). Choose
LANG=C, which is guaranteed toexist. It has the side-effect of typically using an encoding other than
UTF-8 for the tool output (e.g., ISO 8859-1). Apart from messages
printed into the log in this encoding that should hopefully have no
negative side-effects.
See #505 for a case where
code was assuming that output would always be English, and failed if it
wasn't.