Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set remote branch name when doing git push #78

Merged
merged 2 commits into from
Jul 20, 2018

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Jul 20, 2018

Before this change, my local git (version 2.14.1) was setting 6.x as the remote branch for a local backport/6.x/pr-20572. This will ensure the right name is used.

Thanks @sqren for helping me to debug this issue!

Before this change my local git (version 2.14.1) was setting `6.x` as
remote branch for a local `backport/6.x/pr-20572`. This will ensure the
right name is used
@sorenlouv
Copy link
Owner

Thank you so much for this @exekias !
Don't worry about the failing tests. It's due to snapshots that now doesn't match (which I'd expect from this change). I'll fix them and push the change to this PR branch.

@sorenlouv sorenlouv merged commit c3ee625 into sorenlouv:master Jul 20, 2018
@sorenlouv
Copy link
Owner

Released on npm as 4.1.0. I'll bump the version in Kibana later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants