fix(notification-service): notification is read set to false as defau…

…lt (#91) RFIT-568
sourcefuse · Nov 4, 2020 · 17f1060 · 17f1060
1 parent 4343a3f
commit 17f1060
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/services/notification-service/src/component.ts b/services/notification-service/src/component.ts
@@ -34,6 +34,8 @@ import {
   NotificationController,
   NotificationUserController,
   PubnubNotificationController,
+  NotificationNotificationUserController,
+  NotificationUserNotificationController,
 } from './controllers';
 import {NotifServiceBindings} from './keys';
 import {Notification, NotificationAccess, NotificationUser} from './models';
@@ -114,6 +116,8 @@ export class NotificationServiceComponent implements Component {
       NotificationController,
       NotificationUserController,
       PubnubNotificationController,
+      NotificationNotificationUserController,
+      NotificationUserNotificationController,
     ];
   }
 

diff --git a/services/notification-service/src/controllers/notification-user.controller.ts b/services/notification-service/src/controllers/notification-user.controller.ts
@@ -317,7 +317,7 @@ export class NotificationUserController {
 
   private _createFilterBuilder(
     currentUser: IAuthUserWithPermissions,
-    filter?: Filter<NotificationUser>,
+    filter: Filter<NotificationUser> = {},
   ) {
     const filterBuilder = new FilterBuilder(filter);
     if (filter) {

diff --git a/services/notification-service/src/models/notification-user.model.ts b/services/notification-service/src/models/notification-user.model.ts
@@ -31,10 +31,10 @@ export class NotificationUser extends BaseEntity {
 
   @property({
     type: 'boolean',
-    required: true,
+    default: false,
     name: 'is_read',
   })
-  isRead: boolean;
+  isRead?: boolean;
 
   constructor(data?: Partial<NotificationUser>) {
     super(data);