Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bpmn-service): bpmn service component #153

Closed
wants to merge 1 commit into from
Closed

feat(bpmn-service): bpmn service component #153

wants to merge 1 commit into from

Conversation

ihiteshgupta
Copy link
Contributor

@ihiteshgupta ihiteshgupta commented Mar 26, 2021 •
edited
Loading

Description

DO NOT MERGE
bpmn service component added with input validation and versioning for the bpmns

Fixes # (#144)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@ihiteshgupta ihiteshgupta force-pushed the bpmn-service-componenet branch from 01892d8 to 24d81e7 Compare March 26, 2021 13:36
@akshatdubeysf akshatdubeysf force-pushed the bpmn-service-componenet branch 2 times, most recently from 65acbdd to 24d81e7 Compare March 31, 2021 10:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 31, 2021 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.5% 6.5% Duplication

@samarpan-b samarpan-b mentioned this pull request Apr 6, 2021
Merged
8 tasks
@samarpan-b
Copy link
Contributor

Closing in favour of #152

@samarpan-b samarpan-b closed this Apr 17, 2021
@samarpan-b samarpan-b deleted the bpmn-service-componenet branch April 17, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhupesh-sf bhupesh-sf Awaiting requested review from bhupesh-sf

@samarpan-b samarpan-b Awaiting requested review from samarpan-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihiteshgupta @samarpan-b