Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Make deleteById's implementation independent #12

Closed
shubhamp-sf opened this issue Jan 19, 2023 · 1 comment · Fixed by #13
Closed

Make deleteById's implementation independent #12

shubhamp-sf opened this issue Jan 19, 2023 · 1 comment · Fixed by #13
Labels

Comments

@shubhamp-sf
Copy link
Collaborator

Problem

Currently the deleteById function internally calls deleteAll which is problematic when deleteAll is overridden by another mixin such as soft-delete which modifies options resulting in unpredictable outcome.

const result = await this.deleteAll(where, options);

Solution

Make it independent so that it works the way it's expected to.

shubhamp-sf added a commit that referenced this issue Jan 19, 2023
Removed Internal Call of `deleteAll` inside `deleteById` function for predictable outputs

GH-12
shubhamp-sf added a commit that referenced this issue Jan 19, 2023
Removed Internal Call of `deleteAll` inside `deleteById` function for predictable outputs

GH-12
@yeshamavani
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants