Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Update | Readme | Contribution.md #30

Merged
merged 13 commits into from
Feb 2, 2024
Merged

Minor Update | Readme | Contribution.md #30

merged 13 commits into from
Feb 2, 2024

Conversation

vijay-stephen
Copy link
Contributor

Description

Github issue: issue 83

Objective

Please adhere to this format when creating or customizing ARC modules

https://github.com/sourcefuse/terraform-aws-arc-github-iam/blob/main/docs/module-usage-guide/README.md

Please include a CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Performance Tweaks
  • Style Tweaks
  • Code Refactoring
  • Documentation
  • Tests

Work Done

  • Add usage guide and CONTRIBUTING.md
  • update README.md
  • Removed deprecated code and replaced the same with dedicated resource blocks

@vijay-stephen vijay-stephen requested review from mayank0202, tsaucier-sf and jamescrowley321 and removed request for mayank0202 February 1, 2024 11:16
@vijay-stephen vijay-stephen linked an issue Feb 1, 2024 that may be closed by this pull request
update README to include a docs usage and add a contribution file in root #29
Closed
@mayank0202 mayank0202 added the documentation Improvements or additions to documentation label Feb 1, 2024
tsaucier-sf
tsaucier-sf requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@tsaucier-sf tsaucier-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to update ref-arch to arc

@vijay-stephen
Copy link
Contributor Author

Be sure to update ref-arch to arc

checked, its not there in any files

terraform-aws-arc-bootstrap > grep -Ril "refarch" *
example/.terraform/modules/tags/mkdocs.yml
example/.terraform/modules/tags/README.md
example/.terraform/modules/tags/.github/workflows/update-docs.yml
example/.terraform/modules/tags/catalog-info.yaml

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaucier-sf tsaucier-sf merged commit 613ba90 into main Feb 2, 2024
5 checks passed
@tsaucier-sf tsaucier-sf deleted the feature/readme-and-contribution branch February 2, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayank0202 mayank0202 mayank0202 approved these changes

@tsaucier-sf tsaucier-sf tsaucier-sf approved these changes

@jamescrowley321 jamescrowley321 Awaiting requested review from jamescrowley321

Assignees

@vijay-stephen vijay-stephen

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update README to include a docs usage and add a contribution file in root
3 participants
@vijay-stephen @mayank0202 @tsaucier-sf