Split locals for nat gateway ids

[shubhamsinha-sf]

Description

The local for the nat gateway ids was causing issues when custom_nat_gateway_enabled was set to true. This was because terraform needs at least the key to be static for an argument to for_each, and in the case of nat gateways created by the module and the logic that was implemented, the key could only be determined after the apply. This PR is to fix that issue by splitting the local into 2 locals, so that not null condition can be applied on the nat gateway ids from vars, while maintaining the consistency with the nat gateways created within the module.

Related Issue

• Closed issue : Follow up to PR on issue 70.

Checklist

Please ensure that the following steps are completed before submitting the pull request:

• Code follows the Terraform best practices and style guidelines.
• Changes are appropriately documented, including any necessary updates to README or other documentation files.
• Unit tests have been added or updated to cover the changes introduced by this pull request.
• Changes have been tested locally and verified to work as expected.
• The code has been reviewed to ensure it aligns with the project's goals and standards.
• Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Run terraform apply on examples/custom-subnets while changing the values for the module attributes:

• custom_nat_gateway_enabled
• custom_az_ngw_ids

Covering different scenarios.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[jamescrowley321]

LGTM