Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update outputs and docs #81

Merged

Conversation

shubhamsinha-sf
Copy link
Contributor

@shubhamsinha-sf shubhamsinha-sf commented Jun 26, 2024

Description

Update the example and module outputs for custom subnets and nat gateway.

Related Issue

  • issue 80: There is a lot of confusion around using this module for creating a custom scenario with a single nat gateway. The example should be updated with NAT gateway and EIP resources. Also, the module output currently, does not reflects the outputs from the custom subnets submodule, that needs to be updated as well.

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)
  • Documentation (Informative changes)

Testing Instructions

Use the custom subnets example.

Copy link

@mayank0202 mayank0202 merged commit b5192e6 into main Jul 25, 2024
5 checks passed
@mayank0202 mayank0202 deleted the improvement/gh-80-upddate-outputs-and-examples-custom-ngw branch July 25, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants