Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module refactoring #86

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Module refactoring #86

merged 7 commits into from
Oct 25, 2024

Conversation

vijay-stephen
Copy link
Collaborator

@vijay-stephen vijay-stephen commented Oct 23, 2024

Description

Please provide a brief description of the changes introduced by this pull request.

Related Issue

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Testing Instructions

Provide detailed steps or instructions for testing the changes introduced by this pull request.

Screenshots

image

Additional Notes

Add any additional notes or context that might be helpful for reviewers or users testing the changes.

@vijay-stephen vijay-stephen self-assigned this Oct 23, 2024
@vijay-stephen vijay-stephen requested review from manikanta-sadurla and removed request for manikanta-sadurla October 24, 2024 05:25
* Tested Simple and custom exmaples
* Added feature to create subnets easy way
@vijay-stephen vijay-stephen marked this pull request as ready for review October 24, 2024 17:56
tsaucier-sf
tsaucier-sf previously approved these changes Oct 24, 2024
Copy link

@vijay-stephen vijay-stephen linked an issue Oct 25, 2024 that may be closed by this pull request
@vijay-stephen vijay-stephen merged commit 483d0ae into main Oct 25, 2024
5 checks passed
@vijay-stephen vijay-stephen deleted the feature/module-refactor branch October 25, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARC Network - Remove dependency on Cloudose modules
2 participants