Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre commit workflow #25

Merged
merged 8 commits into from
May 30, 2024
Merged

Add pre commit workflow #25

merged 8 commits into from
May 30, 2024

Conversation

mayank0202
Copy link
Contributor

@mayank0202 mayank0202 commented May 2, 2024

Description

Added pre commit workflow

Related Issue

Checklist

Please ensure that the following steps are completed before submitting the pull request:

  • Code follows the Terraform best practices and style guidelines.
  • Changes are appropriately documented, including any necessary updates to README or other documentation files.
  • Unit tests have been added or updated to cover the changes introduced by this pull request.
  • Changes have been tested locally and verified to work as expected.
  • The code has been reviewed to ensure it aligns with the project's goals and standards.
  • Dependencies and backward compatibility have been considered and addressed if applicable.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Testing Instructions

Provide detailed steps or instructions for testing the changes introduced by this pull request.

Screenshots

Include any relevant screenshots or visual aids to help reviewers understand the changes visually, if applicable.

Additional Notes

Add any additional notes or context that might be helpful for reviewers or users testing the changes.

@mayank0202
Copy link
Contributor Author

mayank0202 commented May 6, 2024

@vijay-stephen We need to create an org level Github token so that can be used in pre-commit workflows and can be used in any arc repo too cc: @tsaucier-sf
A classic token works for this perfectly

${{ secrets.GITHUB_TOKEN }}

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mayank0202 mayank0202 merged commit e62c305 into main May 30, 2024
6 checks passed
@mayank0202 mayank0202 deleted the add-pre-commit-workflow branch May 30, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants