Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci-cd): remove hardcoded values in release workflow #36

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

yeshamavani
Copy link
Collaborator

@yeshamavani yeshamavani commented Dec 14, 2023

GH-11

Description

remove hardcoded values from release workflow yml file
update the node version
use lerna v5 for release

Fixes #11

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

Copy link

==== Karma Test Coverage ====
Statements: 27.23% ( 122/448 )
Branches : 11% ( 22 /200 )
Functions : 11.38% ( 14 /123 )
Lines : 27.29% ( 119 /436 )

@yeshamavani yeshamavani merged commit c6339a4 into master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant