Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix the invalid date issue when no time is selected for date/time column #50

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(core): fix the invalid date issue when no time is selected for date/time column #50

merged 1 commit into from
Feb 15, 2024

Conversation

arpit1503khanna
Copy link
Contributor

Description

Fix the invalid date issue when no time is selected for date/time column

Fixes #40

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@github-actions GitHub Actions
Copy link

==== Karma Test Coverage ====
Statements: 27.23% ( 122/448 )
Branches : 11% ( 22 /200 )
Functions : 11.38% ( 14 /123 )
Lines : 27.29% ( 119 /436 )

yeshamavani
yeshamavani requested changes Feb 14, 2024
View reviewed changes
projects/workflows-creator/src/lib/builder/group/group.component.ts Show resolved Hide resolved
projects/workflows-creator/src/lib/builder/group/group.component.ts Outdated
Comment on lines 574 to 577
this.dateTime.time=node.state.get("defaultTime")??"9:00";
}
// else{
// newTime=value.time
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default take as input

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is the default time if no default time is provided

@github-actions GitHub Actions
Copy link

==== Karma Test Coverage ====
Statements: 27.23% ( 122/448 )
Branches : 11% ( 22 /200 )
Functions : 11.38% ( 14 /123 )
Lines : 27.29% ( 119 /436 )

@github-actions GitHub Actions
Copy link

==== Karma Test Coverage ====
Statements: 27.23% ( 122/448 )
Branches : 11% ( 22 /200 )
Functions : 11.38% ( 14 /123 )
Lines : 27.29% ( 119 /436 )

@github-actions GitHub Actions
Copy link

==== Karma Test Coverage ====
Statements: 27.23% ( 122/448 )
Branches : 11% ( 22 /200 )
Functions : 11.38% ( 14 /123 )
Lines : 27.29% ( 119 /436 )

@github-actions GitHub Actions
Copy link

==== Karma Test Coverage ====
Statements: 27.23% ( 122/448 )
Branches : 11% ( 22 /200 )
Functions : 11.38% ( 14 /123 )
Lines : 27.29% ( 119 /436 )

@yeshamavani yeshamavani merged commit 100eb56 into master Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AryanshSourcefuse AryanshSourcefuse AryanshSourcefuse approved these changes

@yeshamavani yeshamavani yeshamavani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Invalid Date' is shown when no time is selected for column 'Date/Time' in worklfow
3 participants
@arpit1503khanna @yeshamavani @AryanshSourcefuse