Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow date to be set on enter #61

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix(core): allow date to be set on enter #61

merged 2 commits into from
Feb 22, 2024

Conversation

arpit1503khanna
Copy link
Contributor

Description

Allow date to be set on enter

Fixes #56

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

Copy link

==== Karma Test Coverage ====
Statements: 26.2% ( 125/477 )
Branches : 10.71% ( 24 /224 )
Functions : 12% ( 15 /125 )
Lines : 26.23% ( 122 /465 )

Copy link

==== Karma Test Coverage ====
Statements: 26.2% ( 125/477 )
Branches : 10.71% ( 24 /224 )
Functions : 12% ( 15 /125 )
Lines : 26.23% ( 122 /465 )

Copy link

@a-ganguly a-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow date to be set on enter

@a-ganguly a-ganguly merged commit daf0ab2 into master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect date is fetched using keyboard in "Do this" block
2 participants