fix(core): allow only 4 digits for year in date input #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpit1503khanna
force-pushed
the
GH-56
branch
from
8e9803f to
c986b61
Compare
|
==== Karma Test Coverage ==== |
AryanshSourcefuse
approved these changes
Feb 26, 2024
yeshamavani
reviewed
Feb 26, 2024
Comment on lines
+599
to
606
| ) { | ||
| const response = this.getLibraryValue(node, $event, type, {}); | ||
|
|
||
| //check whether the entered key is "ENTER" key | ||
| if (event.keyCode === 13) { | ||
| callback(response); | ||
| } | ||
| } |
There was a problem hiding this comment.
is this a breaking change ?
yeshamavani
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #56
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: