Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Save button is disabled for complete workflows #66

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

Deepika516
Copy link
Collaborator

Save button is disabled for complete workflows

Fixes #65

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

Copy link

==== Karma Test Coverage ====
Statements: 26.15% ( 125/478 )
Branches : 10.71% ( 24 /224 )
Functions : 12% ( 15 /125 )
Lines : 26.18% ( 122 /466 )

Comment on lines 9 to 14
"@angular/common": "13.3.0",
"@angular/core": "~13.3.11",
"@angular/forms": "13.3.0",
"bpmn-moddle": "^8.0.0",
"lodash": "^4.17.21",
"ngx-popperjs": "^13.3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

fix save button enable on valid WF

GH-65
@Deepika516 Deepika516 added the bug Something isn't working label Feb 27, 2024
Copy link

==== Karma Test Coverage ====
Statements: 26.15% ( 125/478 )
Branches : 10.71% ( 24 /224 )
Functions : 12% ( 15 /125 )
Lines : 26.18% ( 122 /466 )

@yeshamavani yeshamavani merged commit 4a74954 into master Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow: Save button is disabled for complete workflows
2 participants