Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Values are not retained after saving for 'Else Do this' block #73

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

Deepika516
Copy link
Collaborator

WF| Values are not retained after saving for 'Else Do this' block when 'Item/Subitem is created' is selected in the workflow
for further information please check the following link
GH-71

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #71

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Deepika516 Deepika516 self-assigned this Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

==== Karma Test Coverage ====
Statements: 25.4% ( 125/492 )
Branches : 10.52% ( 24 /228 )
Functions : 11.9% ( 15 /126 )
Lines : 25.41% ( 122 /480 )

Copy link

github-actions bot commented Mar 1, 2024

==== Karma Test Coverage ====
Statements: 25.4% ( 125/492 )
Branches : 10.52% ( 24 /228 )
Functions : 11.9% ( 15 /126 )
Lines : 25.41% ( 122 /480 )

Copy link

github-actions bot commented Mar 4, 2024

==== Karma Test Coverage ====
Statements: 25.15% ( 125/497 )
Branches : 10.3% ( 24 /233 )
Functions : 11.9% ( 15 /126 )
Lines : 25.15% ( 122 /485 )

Copy link

==== Karma Test Coverage ====
Statements: 25.39% ( 128/504 )
Branches : 10.69% ( 26 /243 )
Functions : 12.59% ( 16 /127 )
Lines : 25.4% ( 125 /492 )

fix retain else block on edit button

GH-71
review chnages in fix of else column

GH-71
Copy link

==== Karma Test Coverage ====
Statements: 41.6% ( 773/1858 )
Branches : 24.46% ( 207 /846 )
Functions : 37.95% ( 156 /411 )
Lines : 41.11% ( 731 /1778 )

@yeshamavani yeshamavani merged commit 284545b into master Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants