feat(core): add tooltip support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
==== Karma Test Coverage ==== |
akshatdubeysf
requested changes
Apr 13, 2023
| @@ -58,6 +58,9 @@ export class BuilderComponent<E> implements OnInit, OnChanges { | |||
| @Input() | |||
| state: StateMap<RecordOfAnyType> = {}; | |||
|
|
|||
| @Input() | |||
| localizedStringMap: {[key: string]: string}; | |||
There was a problem hiding this comment.
Instead of passing this everywhere, why not just create a common service, register the map in that service here in this component, than inject that service and use the values from there whenever you need to, or you can even create a simple pipe to fetch that information from that service in html
akshatdubeysf
approved these changes
Apr 13, 2023
maninder-pal-singh
force-pushed
the
GH-5
branch
from
09ef6dd to
47b877e
Compare
|
==== Karma Test Coverage ==== |
nileshkumar-sf
added a commit
that referenced
this pull request
Apr 25, 2023
…is already selected GH-8
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
should be merged after #5
adds tooltip support over prompts
Fixes GH-5
Type of change
Checklist: