Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update DB links in docs #1084

Merged
merged 5 commits into from
Jul 14, 2020
Merged

[MRG] Update DB links in docs #1084

merged 5 commits into from
Jul 14, 2020

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jul 7, 2020

I used the OSF links in the last commit, but I can revert it and use the S3 links instead (the first commit here does that).

Connected to #1036 , but still not providing a catalog (as discussed in #1005)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1084 into master will increase coverage by 9.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   83.86%   92.96%   +9.10%     
==========================================
  Files          98       74      -24     
  Lines        9108     5787    -3321     
==========================================
- Hits         7638     5380    -2258     
+ Misses       1470      407    -1063     
Flag Coverage Δ
#rusttests ?
Impacted Files Coverage Δ
src/core/tests/minhash.rs
src/core/src/index/bigsi.rs
src/core/src/cmd.rs
src/core/src/index/sbt/mhbt.rs
src/core/src/index/sbt/mod.rs
src/core/src/ffi/nodegraph.rs
src/core/src/index/linear.rs
src/core/src/ffi/minhash.rs
src/core/src/index/search.rs
src/core/src/signature.rs
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6800f1...bc1d1b9. Read the comment docs.

@ctb
Copy link
Contributor

ctb commented Jul 8, 2020

I think the s3 link download would be faster, right?

I'd like to add the catalogs as well as a link to the top level osf project at https://osf.io/t3fqa/, I think. Working on generating the almeida etc catalogs.

@ctb
Copy link
Contributor

ctb commented Jul 8, 2020

the manifests are now up on osf.io, in OSF storage.

@ctb ctb changed the title Update DB links in docs [MRG] Update DB links in docs Jul 14, 2020
@ctb
Copy link
Contributor

ctb commented Jul 14, 2020

I think this is ready for review & merge @luizirber

@luizirber luizirber merged commit 2872aa5 into master Jul 14, 2020
@luizirber luizirber deleted the doc/new_zip_dbs branch July 14, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants