-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Update DB links in docs #1084
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 83.86% 92.96% +9.10%
==========================================
Files 98 74 -24
Lines 9108 5787 -3321
==========================================
- Hits 7638 5380 -2258
+ Misses 1470 407 -1063
Continue to review full report at Codecov.
|
I think the s3 link download would be faster, right? I'd like to add the catalogs as well as a link to the top level osf project at https://osf.io/t3fqa/, I think. Working on generating the almeida etc catalogs. |
the manifests are now up on osf.io, in OSF storage. |
I think this is ready for review & merge @luizirber |
I used the OSF links in the last commit, but I can revert it and use the S3 links instead (the first commit here does that).
Connected to #1036 , but still not providing a catalog (as discussed in #1005)
Checklist
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?