Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: switch to using in_dir instead of try/finally for one last test #487

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Oct 26, 2024

Fixes #447

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ctb ctb merged commit 12eca77 into main Nov 1, 2024
3 checks passed
@ctb ctb deleted the refactor_tests branch November 1, 2024 22:44
@ctb ctb mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor tests to use runtmp.sourmash(..., in_directory=...) instead of try/finally
2 participants