Disable dock show on dispose (#38)

Prevent flash of macOS dock icon during auto-updates. Fixes #36.
soutar · Feb 26, 2018 · 1cab7c5 · 1cab7c5
1 parent aed5bf8
commit 1cab7c5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/modules/__tests__/dispose.test.js b/modules/__tests__/dispose.test.js
@@ -24,10 +24,6 @@ describe('dispose', () => {
     expect(showWindows).toHaveBeenCalledTimes(1);
   });
 
-  it('shows the dock icon', () => {
-    expect(app.dock.show).toHaveBeenCalledTimes(1);
-  });
-
   it('unsubscribes from config changes', () => {
     expect(cfgUnsubscribeMock).toHaveBeenCalledTimes(1);
   });

diff --git a/modules/dispose.js b/modules/dispose.js
@@ -5,9 +5,6 @@ module.exports = (app, callbacks = {}) => {
   const { cfgUnsubscribe, handleActivate, handleBlur } = callbacks;
 
   showWindows(app);
-  if (app.dock) {
-    app.dock.show();
-  }
   // TODO: Unregister shortcut when supported
   // unregisterShortcut()