Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default return value in setCustomTransformer callback function #65

Conversation

kungpaogao
Copy link
Contributor

@kungpaogao kungpaogao commented Apr 7, 2023

Context

Changes

  • do not return value if custom transformer returns false

Test Plan

  • added unit tests to test actual implementation of custom transformers

@souvikinator
Copy link
Owner

looks good to me. It should be live in the upcoming version. Thanks for contributing :))

@kungpaogao
Copy link
Contributor Author

yay! feel free to merge when you're ready :)

@souvikinator souvikinator merged commit b8e75bd into souvikinator:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Add default return value in setCustomTransformer callback function
2 participants