Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented DJANGO_EASY_AUDIT_PROPAGATE_EXCEPTIONS setting #248

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Implemented DJANGO_EASY_AUDIT_PROPAGATE_EXCEPTIONS setting #248

merged 4 commits into from
Apr 19, 2023

Conversation

dferens
Copy link
Contributor

@dferens dferens commented Mar 13, 2023

Hi @jheld ,

This is a PR for #247 , let me know if there's something I need to change.

mschoettle
mschoettle suggested changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@mschoettle mschoettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a maintainer so am providing community feedback. Added a couple of comments.

I like this extra setting. Every once in a while I see some exceptions in pytest output that are suppressed.

README.md Outdated Show resolved Hide resolved
easyaudit/signals/auth_signals.py Outdated Show resolved Hide resolved
@dferens
Copy link
Contributor Author

dferens commented Mar 26, 2023

Hi @jheld , I reworked PR for a single setting and added test.

mschoettle
mschoettle reviewed Apr 1, 2023
View reviewed changes
Copy link
Contributor

@mschoettle mschoettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

There are a few lines (raises e) where no should_propagate_exceptions() is called first. Are those checks missing there?

@dferens
Copy link
Contributor Author

dferens commented Apr 1, 2023

There are a few lines (raises e) where no should_propagate_exceptions() is called first. Are those checks missing there?

I only modified top-level try/catch blocks, not sure if we need to change inner ones.

@dferens dferens changed the title Implemented DJANGO_EASY_AUDIT_DEBUG_SIGNALS setting Implemented DJANGO_EASY_AUDIT_PROPAGATE_EXCEPTIONS setting Apr 6, 2023
@dferens
Copy link
Contributor Author

dferens commented Apr 17, 2023

Hi, how can we proceed with this?

@jheld jheld merged commit fc50e33 into soynatan:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschoettle mschoettle mschoettle requested changes

@jheld jheld jheld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dferens @jheld @mschoettle