Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added compatibility to bundlers (closes #144 #152 #153) #154

Closed
wants to merge 1 commit into from
Closed

Added compatibility to bundlers (closes #144 #152 #153) #154

wants to merge 1 commit into from

Conversation

tabarra
Copy link
Contributor

@tabarra tabarra commented Sep 15, 2022

Q A
Branch? main
Bug fix? yes
New feature? yes
Deprecations? no
Tickets Fix #144 #152 #153
License MIT
Doc PR not required

@simonepri
Copy link
Collaborator

Hi tabara@ thank you for the PR.

I think the change should look like more like this (i.e. we need to introduce a methodToRequireFn function):
simonepri/pidtree@d3fb048

@simonepri simonepri self-requested a review September 21, 2022 14:27
@tabarra
Copy link
Contributor Author

tabarra commented Sep 22, 2022

@simonepri Maybe, but that's fine because node caches modules so it's only actually included once.
I had to rush it just to be able to ship an update in my project, but might revisit it in the future.

@soyuka soyuka mentioned this pull request Oct 25, 2022
Merged
@soyuka
Copy link
Owner

soyuka commented Oct 25, 2022

thanks kept your commits in #163 and added the change with as we'll need probably need it in #143

@soyuka soyuka closed this Oct 25, 2022
soyuka added a commit that referenced this pull request Oct 25, 2022
@soyuka @tabarra
Added compatibility to bundlers (closes #144 #152 #153) #154 (#163)
61480f7 
* feat: added bundling compatibility

* chore: 3.0.1 changelog

* fix: use methods for require to prepare gwmi

Co-authored-by: tabarra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonepri simonepri Awaiting requested review from simonepri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux is not supported yet README shows it as supported?
3 participants
@tabarra @simonepri @soyuka